refactor: add storeResults/loadResults for Spectra etc#749
Merged
philouail merged 1 commit intoimport_methodsfrom May 30, 2024
Merged
refactor: add storeResults/loadResults for Spectra etc#749philouail merged 1 commit intoimport_methodsfrom
philouail merged 1 commit intoimport_methodsfrom
Conversation
philouail
approved these changes
May 30, 2024
Collaborator
philouail
left a comment
philouail
left a comment
There was a problem hiding this comment.
thanks for the notes and ideas !! I'll merge and start working on that
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some thoughts on how to maybe implement the text import/export in a more future-proof (and modular) way.